search

laminas-api-tools / api-tools

Laminas API Tools module for Laminas
https://api-tools.getlaminas.org/documentation
BSD 3-Clause "New" or "Revised" License
37 stars 19 forks source link

Make tests compatible with hydrator 3 #76

Closed alexdenvir closed 4 years ago

alexdenvir commented 4 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Builds were failing using latest dependencies on php 7.2+, because Laminas\Hydrator 3.0.0 deprecated the ClassMethods hydrator.

This PR tries to remain backwards compatible by checking if the replacement for ClassMethods is available. This is obviously just a stopgap, as a better solution may be to release a new version that bumps the minimum php version to 7.2 and drop the backwards compatibility altogether

alexdenvir commented 4 years ago

Also, I hope I'm not getting ahead of myself fixing broken builds. I'll hold off if its a nuisance to maintainers

michalbundyra commented 4 years ago

@alexdenvir

Also, I hope I'm not getting ahead of myself fixing broken builds. I'll hold off if its a nuisance to maintainers

No, I really appreciate your work! :) Thanks a lot 👍

alexdenvir commented 4 years ago

Cool, I'll keep going then :wink:

michalbundyra commented 4 years ago

Thanks, @alexdenvir!