search

laminas / automatic-releases

Automated release process for `laminas/` projects, usable as github action
Other
141 stars 22 forks source link

Missing Git LFS support #179

Closed snapshotpl closed 2 years ago

snapshotpl commented 2 years ago

Feature Request

Q A
New Feature yes
RFC no
BC Break no

Summary

When run on lfs git repository:

In execute.php line 82:

  [Psl\Shell\Exception\FailedExecutionException (1)]                           
  Shell command "git 'checkout' '1.0.x'" returned an exit code of "1".         

  STDOUT:                                                                      

  STDERR:                                                                      
      Already on '1.0.x'                                                       
      \nThis repository is configured for Git LFS but 'git-lfs' was not found  
   on your path. If you no longer wish to use Git LFS, remove this hook by de  
  leting '.git/hooks/post-checkout'.\n                                         

Exception trace:
  at /app/vendor/azjezz/psl/src/Psl/Shell/execute.php:82
 Psl\Shell\execute() at /app/src/Git/CreateTagViaConsole.php:26
 Laminas\AutomaticReleases\Git\CreateTagViaConsole->__invoke() at /app/src/Application/Command/ReleaseCommand.php:108
 Laminas\AutomaticReleases\Application\Command\ReleaseCommand->execute() at /app/vendor/symfony/console/Command/Command.php:256
 Symfony\Component\Console\Command\Command->run() at /app/vendor/symfony/console/Application.php:971
 Symfony\Component\Console\Application->doRunCommand() at /app/vendor/symfony/console/Application.php:290
 Symfony\Component\Console\Application->doRun() at /app/vendor/symfony/console/Application.php:[16](https://github.com/xxx/runs/5572604814?check_suite_focus=true#step:4:16)6
 Symfony\Component\Console\Application->run() at /app/bin/console.php:[17](https://github.com/xxx/runs/5572604814?check_suite_focus=true#step:4:17)1
 Laminas\AutomaticReleases\WebApplication\{closure}() at /app/bin/console.php:172

laminas:automatic-releases:release
Ocramius commented 2 years ago

I suppose it needs to be added somewhere in our Dockerfile? Never used git-lfs on OSS projects, so it's something that I don't know how to test directly.

glensc commented 2 years ago

I suppose it needs to be added somewhere in our Dockerfile? Never used git-lfs on OSS projects, so it's something that I don't know how to test directly.

Yes, and I think the install is also needed:

RUN apk add --no-cache git-lfs && git lfs install --skip-repo
snapshotpl commented 2 years ago

I will provide PR, but no idea how to test it manually before release...