search

laminas / automatic-releases

Automated release process for `laminas/` projects, usable as github action
Other
141 stars 22 forks source link

Known limitation: can only handle the first 100 issues/PRs in a release #6

Open asgrim opened 4 years ago

asgrim commented 4 years ago

Bug Report

Q A
Version(s) 1.0.0

Summary

This is a known limitation currently.

Ocramius commented 4 years ago

Affected code:

https://github.com/laminas/automatic-releases/blob/ea0062141bd984f60e4364600570487cec91b0d2/src/Github/Api/GraphQL/Query/GetMilestoneFirst100IssuesAndPullRequests.php#L12

An alternative implementation that can use graphql pagination is needed here.

Slamdunk commented 4 years ago

Or, you know, you can write better software, so each release has fewer bugs or errors and hence few issues/PR

Ocramius commented 4 years ago

Hahahahahaha :D

Well, as it stands, that implementation is non-total, which is a clear bug. Whether it affects you is secondary :+1: