search

laminas / automatic-releases

Automated release process for `laminas/` projects, usable as github action
Other
141 stars 23 forks source link

#8 restore `laminas/automatic-releases` CLI application version parsing #9

Open Ocramius opened 4 years ago

Ocramius commented 4 years ago

In #8 and #10, we disable version parsing by removing .git from the Dockerfile: we will need to re-enable it again, so that the correct application version can be rendered in case of bugs:

https://github.com/laminas/automatic-releases/blob/ea0062141bd984f60e4364600570487cec91b0d2/bin/console.php#L68

weierophinney commented 4 years ago

How do you suggest making this happen? Cloning the repo into /app within Dockerfile? Or a release action that sets the release version in a placeholder?

Ocramius commented 4 years ago

I think GitHub actions contain an implicit env var with the action name+version: to be checked 👍