search

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Upgrade laminas-coding-standard to 2.3 #22

Closed arueckauer closed 2 years ago

arueckauer commented 2 years ago
Q A
QA yes

Description

This PR updates the laminas-coding-standard to version 2.3.0 and provides necessary code changes.

Ocramius commented 2 years ago

@froschdesign beware: you adjusted milestone to 2.9.0, but the target branch states 3.0.x

froschdesign commented 2 years ago

@Ocramius Right, the target branch is wrong. But there is no 2.9.0 branch and that doesn't mean we need a major version to update the coding standard.

arueckauer commented 2 years ago

How would you like to proceed? Create a 2.9.x branch and I rebase to it?

arueckauer commented 2 years ago

@Ocramius & @froschdesign It looks like the tests are missing some env configuration (?). How can that be solved?

arueckauer commented 2 years ago

@froschdesign / @Ocramius Originally this was branched off of the default branch 3.0.x. Should I rebase to 2.9.x?

froschdesign commented 2 years ago

@arueckauer

Should I rebase to 2.9.x?

Yes, please! (some more cherry-pick is needed)

Ocramius commented 2 years ago

I think the 2.9.x and 3.0.x now already have some half-phpcs setup - needs some checking (and potentially rebasing or closing, depending on outcome)