search

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Removed dependency on laminas/laminas-zendframework-bridge #25

Closed Koen1999 closed 2 years ago

Koen1999 commented 2 years ago

Removed dependency on laminas/laminas-zendframework-bridge This should increase performance once other laminas packages do so too.

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA yes
Koen1999 commented 2 years ago

To me it seems as if the CI runner is not using the updated phpunit.xml file present in the PR. Locally the deprecation warning is converted to an error causing the tests to pass. Also using phpunit 9.5.10.

froschdesign commented 2 years ago

@Koen1999 Have you seen the following message?

Warning: Your XML configuration validates against a deprecated schema. Suggestion: Migrate your XML configuration using "--migrate-configuration"!

https://github.com/laminas/laminas-authentication/runs/4395560134?check_suite_focus=true#step:3:433

Koen1999 commented 2 years ago

@Koen1999 Have you seen the following message?

Warning: Your XML configuration validates against a deprecated schema. Suggestion: Migrate your XML configuration using "--migrate-configuration"!

https://github.com/laminas/laminas-authentication/runs/4395560134?check_suite_focus=true#step:3:433

Yes, I have. But it confused me a bit.

laminas-authentication$ php8.0 vendor/bin/phpunit --migrate-configuration -c phpunit.xml.dist
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

laminas-authentication/phpunit.xml.dist does not need to be migrated.

Edit: I just noticed there's a second configuration file