search

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 16 forks source link

PHP 8.1 support #26

Closed tobias-trozowski closed 2 years ago

tobias-trozowski commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Based on https://github.com/laminas/laminas-authentication/pull/24

query results of sqlite have changed in php 8.1, see https://bugs.php.net/bug.php?id=38334 Fixed bug #38334 (Proper data-type support for PDO_SQLITE). (https://www.php.net/ChangeLog-8.php)

Fixes #24 Fixes #23

Koen1999 commented 2 years ago

I think this solution could be appropriate if tests pass.

Koen1999 commented 2 years ago

On the other hand, it also avoids the problem by adjusting the test. Users of this function may still experience bugs due to the changed type.

Ocramius commented 2 years ago

Users of this function may still experience bugs due to the changed type.

Not fixable on this end: that requires a better DB abstraction then :-\

Koen1999 commented 2 years ago

I would also like to thank @Ocramius, @snapshotpl and @froschdesign for enabling me to help adding PHP 8.1 support to several Laminas repositories :)

My study association has greatly benefited from the work you have done on Laminas, and your predecessors on Zend framework.