laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Adjust conflicts in `2.9.x` -> `3.0.x` merge-up #28

Closed tobias-trozowski closed 2 years ago

tobias-trozowski commented 2 years ago

Fixed conflicts in merge-up

Ocramius commented 2 years ago

Hmm, 7.3 builds failed 🤔

tobias-trozowski commented 2 years ago

i might have used the wrong container for updating the lock file after merge... :O

tobias-trozowski commented 2 years ago

@Ocramius cant reproduce the error with phpcs locally, any idea?

Ocramius commented 2 years ago

Perhaps we can attempt removing TestAsset exclusions?

Warning: No PHP code was found in this file and short open tags are not allowed by this install of PHP. This file may be using short open tags but PHP does not allow them.

I don't know where this may be coming from either: the -q flag makes it annoyingly hard to figure it out :|

tobias-trozowski commented 2 years ago

any chance to alter the workflow command without changing laminas/laminas-ci-matrix-action?

Ocramius commented 2 years ago

I'd rather suggest running the action docker container locally

tobias-trozowski commented 2 years ago

Found it...

Running ./vendor/bin/phpcs
.............................................W.......

FILE: /github/workspace/test/Adapter/DbTableTest.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 1 | WARNING | No PHP code was found in this file and short open tags
   |         | are not allowed by this install of PHP. This file may
   |         | be using short open tags but PHP does not allow them.
----------------------------------------------------------------------
tobias-trozowski commented 2 years ago

is it possible to merge this and PR and #27 or are they waiting for anything?

Ocramius commented 2 years ago

@tobias-trozowski mostly oversight - didn't receive further notifications about it, hence it was ignored :)