Update minimum PHP version to 7.4, update `phpunit/phpunit` to `^9.3.4` and `laminas/laminas-coding-standard` to `~2.4.0`

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios

https://docs.laminas.dev/laminas-authentication/

BSD 3-Clause "New" or "Revised" License

24 stars 15 forks source link

Update minimum PHP version to 7.4, update `phpunit/phpunit` to `^9.3.4` and `laminas/laminas-coding-standard` to `~2.4.0` #41

Closed internalsystemerror closed 2 years ago

internalsystemerror commented 2 years ago

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

This PR:

Updates the minimum supported PHP version to 7.4
Updates phpunit/phpunit to ^9.3.4 as the XSD is required for CI (see https://github.com/laminas/laminas-authentication/runs/8287606784?check_suite_focus=true)
Updates all dependencies to the minimum installed versions on PHP 7.4
Updates laminas/laminas-coding-standard to ~2.4.0 (closes https://github.com/laminas/laminas-authentication/pull/40 and allows https://github.com/laminas/laminas-authentication/pull/39 to proceed once regenerated)

internalsystemerror commented 2 years ago

I'm not sure what milestone to attach to. I checked out 2.11.x thinking that was the future minor. This should technically be part of 2.12.x. How does that work with automatic-releases?

gsteel commented 2 years ago

2.12.x should be fine right - Automatic releases will just create a merge-up for 3.0.x

internalsystemerror commented 2 years ago

There currently is no 2.12.x branch. But if I merge this and add it to the 2.12.0 milestone, then there will be changes on the 2.11.x branch without a 2.11.1 release. I wonder if could just create the branch manually?

internalsystemerror commented 2 years ago

Branch created, through the UI too, was easy enough.

Ocramius commented 2 years ago