search

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

[WIP] Evented implementation for Zend Auth #7

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

I've been playing around with making the core of Zend Auth event based, this is very much a WIP but the idea is to support the use cases in the cookbook directory.

Feedback would be appreciated; if it is agreed that this is the right direction to go, I can finish off the code: add tests, docs and migrate the existing adapters to listeners.

Originally posted by @carnage at https://github.com/zendframework/zend-authentication/pull/7

weierophinney commented 4 years ago

After talking with @akrabat at PHPUK I've updated this adding back in some backward compatibility.

The remaining BC breaks are:

authenticate method used to take an adapter; this doesn't quite make sense via the new event based internals and instead needs to take parameters to authenticate against.

I've removed the get/set adapter methods and replaced with an addAdapter method (get/set makes no sense with multiple adapter setup)

It should be noted however that the service still complies with it's interface.

Originally posted by @carnage at https://github.com/zendframework/zend-authentication/pull/7#issuecomment-186897972

weierophinney commented 4 years ago

@carnage If you're still interested in this approach (and it does look interesting!), please rebase against current develop and re-target the PR against that branch so we can review.

Thanks!

Originally posted by @weierophinney at https://github.com/zendframework/zend-authentication/pull/7#issuecomment-380918292

weierophinney commented 4 years ago

I'd totally forgotten about this PR

Will try and get some time to bring it up to spec in the next few weeks

Originally posted by @carnage at https://github.com/zendframework/zend-authentication/pull/7#issuecomment-381950027

weierophinney commented 4 years ago

@weierophinney how keen are you to preserve BC here? Zend auth has basically remained the same since ZF1 and could really use a bit of refactoring (eg adaptors which require you to set them up in advance as opposed to authenticating against given paramters)

Originally posted by @carnage at https://github.com/zendframework/zend-authentication/pull/7#issuecomment-410521813