search

laminas / laminas-authentication

provides an API for authentication and includes concrete authentication adapters for common use case scenarios
https://docs.laminas.dev/laminas-authentication/
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

remove @deprecated class and method #9

Closed weierophinney closed 3 years ago

weierophinney commented 4 years ago

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2

weierophinney commented 4 years ago

bump php version in composer :-)

Originally posted by @vaclavvanik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-108829073

weierophinney commented 4 years ago

@vaclavvanik This PR does not imply a change in PHP requirements.

Originally posted by @Maks3w at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-108830012

weierophinney commented 4 years ago

Oh, you are right. I thought rashly

Originally posted by @vaclavvanik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-108832313

weierophinney commented 4 years ago

rebased

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-109490058

weierophinney commented 4 years ago

I'll close this until v3 development of this component begin

Originally posted by @Maks3w at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-109812195

weierophinney commented 4 years ago

:(. this is why I think we need to have per-branch : 2.4, 2.5, 2.6, 3.0 , early works merged is better imo. //cc @gianarb @weierophinney

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-109826769

weierophinney commented 4 years ago

This can begin now on the develop branch. Essentially, this PR is indicating that we have developers wanting to work on BC-breaking changes, which means that the develop branch should become the 3.0 branch. I'll review, and, on merge, bump the branch aliases for the develop branch.

Originally posted by @weierophinney at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-110043990

weierophinney commented 4 years ago

mergeable? Or i should re-create PR against develop branch?

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-229833623

weierophinney commented 4 years ago

@weierophinney I've changed target branch to develop

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-245891215

weierophinney commented 4 years ago

@weierophinney merge-able ?

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-254091657

weierophinney commented 4 years ago

Is there anything I can do to get it merged? Thank you.

Originally posted by @samsonasik at https://github.com/zendframework/zend-authentication/pull/2#issuecomment-313709218

samsonasik commented 4 years ago

I've created PR https://github.com/laminas/laminas-authentication/pull/11 for it.

froschdesign commented 3 years ago

Fixed with #11 and will be released with version 3.0.0.