Handle non-array return values for `RedisCluster#mget`

laminas / laminas-cache-storage-adapter-redis

BSD 3-Clause "New" or "Revised" License

8 stars 12 forks source link

Handle non-array return values for `RedisCluster#mget` #75

Closed boesing closed 1 year ago

boesing commented 1 year ago

Q	A
Bugfix	yes

Description

As per https://github.com/phpredis/phpredis/blob/35a7cc094c6c264aa37738b074c4c54c4ca73b87/redis_cluster.stub.php#L621, the RedisCluster#mget method can return non-array values:

RedisCluster in case we are within multi mode
false in case there was an error which did not end up in an RedisClusterException

Fixes #74

boesing commented 1 year ago

I am unable to enforce an internal redis error so that false is not testable. Unless some1 has a tipp for me, I just handle the return value as annotated rather than testing any use-case.