search

laminas / laminas-cache

Caching implementation with a variety of storage options, as well as codified caching strategies for callbacks, classes, and output
https://docs.laminas.dev/laminas-cache/
BSD 3-Clause "New" or "Revised" License
103 stars 52 forks source link

Update to use PHP 8.1 syntax #345

Closed samsonasik closed 10 hours ago

samsonasik commented 3 weeks ago
Q A
QA yes

Description

Since composer.json require php 8.1, php 8.1 syntax can be applied.

samsonasik commented 3 weeks ago

Ready for review 👍 Test failure is unrelated, as I tested equal result in 4.1.x

➜  laminas-cache git:(4.1.x) vendor/bin/phpunit test/Psr/CacheItemPool/CacheItemTest.php
PHPUnit 9.6.21 by Sebastian Bergmann and contributors.

......F...F                                                       11 / 11 (100%)

Time: 00:00.012, Memory: 6.00 MB

There were 2 failures:

1) LaminasTest\Cache\Psr\CacheItemPool\CacheItemTest::testExpiresAfterInt
Failed asserting that 7200 matches expected 3600.

/Users/samsonasik/www/laminas/laminas-cache/test/Psr/CacheItemPool/CacheItemTest.php:89

2) LaminasTest\Cache\Psr\CacheItemPool\CacheItemTest::testClockProvidedDoesNotContainUTCTimeZone
Failed asserting that 7200 matches expected 3600.

/Users/samsonasik/www/laminas/laminas-cache/test/Psr/CacheItemPool/CacheItemTest.php:147
gsteel commented 1 day ago

Can you try a rebase here please @samsonasik ?

samsonasik commented 17 hours ago

@gsteel rebased 👍