Closed sergiy-v closed 2 years ago
@Ocramius hello) Since we have conflict here I would like to clarify - would you like to have the working branch updated to 2.12.x or should I create a new PR? I could update the working branch but name starting with 2.11.x with code for 2.12.x may confuse a bit, so it's fine for me to create a new PR. Please clarify.
Hey @sergiy-v, a couple things:
2.11.x
should not receive dependency changes: the reason being that patch releases should always allow for easy upgrades, since they may be security issues. In an x.y.z
versioning scheme, never change dependencies in a z
versioncomposer.json
changes, applying them to 2.12.x
, updating composer.lock
accordingly, then committing and force-pushing to this branch.If you prefer to do a new PR, that is fine too :)
Hey @sergiy-v, a couple things:
2.11.x
should not receive dependency changes: the reason being that patch releases should always allow for easy upgrades, since they may be security issues. In anx.y.z
versioning scheme, never change dependencies in az
version- It may be worth taking your
composer.json
changes, applying them to2.12.x
, updatingcomposer.lock
accordingly, then committing and force-pushing to this branch.If you prefer to do a new PR, that is fine too :)
@Ocramius thank you for the details. Sorry, I totally missed point 1. I have created a new PR for the changes, so closing this one.
Description
Added require dependencies (laminas/laminas-recaptcha, laminas/laminas-session, laminas/laminas-text, laminas/laminas-validator) to require section to fix the following issues: Fixes #18 Fixes #16