search

laminas / laminas-captcha

Generate and validate CAPTCHAs using Figlets, images, ReCaptcha, and more
https://docs.laminas.dev/laminas-captcha/
BSD 3-Clause "New" or "Revised" License
24 stars 13 forks source link

BC break introduced with 2.7 ? #3

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

Seems like 2.7 introduced BC breaks. We experiences a failure (Public key not found) with updating from 2.6 to 2.7. Basically we had in our composer.json:

"zendframework/zend-captcha": "^2.6",
"zendframework/zendservice-recaptcha": "^2.0.1",

We switched back to 2.6 for now until we make sure we can go ahead with zendservice-recaptcha v3.

Originally posted by @mheki at https://github.com/zendframework/zend-captcha/issues/34

weierophinney commented 4 years ago

@mheki an example failure would help

Originally posted by @Ocramius at https://github.com/zendframework/zend-captcha/issues/34#issuecomment-292576573

weierophinney commented 4 years ago

@Ocramius I debugged further. We got this exception:

ZendService\ReCaptcha\Exception: Missing public key in C:\Apache24\htdocs\www\vendor\zendframework\zendservice-recaptcha\library\ZendService\ReCaptcha\ReCaptcha.php on line 380

because of: v2.6: https://github.com/zendframework/zend-captcha/blob/release-2.6.0/src/ReCaptcha.php#L129-L134 vs v2.7 https://github.com/zendframework/zend-captcha/blob/release-2.7.0/src/ReCaptcha.php#L167-L180

We've been passing $options['private_key' => ..., 'public_key' => ...] obviously.

Originally posted by @mheki at https://github.com/zendframework/zend-captcha/issues/34#issuecomment-292920274