PHP 8 support - Githubissues

laminas / laminas-captcha

Generate and validate CAPTCHAs using Figlets, images, ReCaptcha, and more

https://docs.laminas.dev/laminas-captcha/

BSD 3-Clause "New" or "Revised" License

25 stars 14 forks source link

PHP 8 support #7

Closed tanerkay closed 3 years ago

tanerkay commented 3 years ago

Q A New Feature yes

Description

Addresses https://github.com/laminas/laminas-captcha/issues/6

Caveats:

waiting on two upstream dependencies for PHP 8 support:
- laminas/laminas-math
- laminas/laminas-recaptcha

froschdesign commented 3 years ago

@tanerkay Thanks for your contribution! 👍

waiting on two upstream dependencies for PHP 8 support…

In the meantime you can fix some other problems like:

PHP Fatal error:  Declaration of LaminasTest\Captcha\ImageTest::tearDown() must be compatible
with PHPUnit\Framework\TestCase::tearDown(): void
in /home/travis/build/laminas/laminas-captcha/test/ImageTest.php on line 65

https://travis-ci.com/github/laminas/laminas-captcha/jobs/470269060#L473

Thanks in advance!

sivaschenko commented 3 years ago

Hi @tanerkay @froschdesign are there any expectation when the PHP 8 support could be available?

Looks like laminas/laminas-math is already compatible with PHP 8 And https://github.com/laminas/laminas-recaptcha/pull/5 is ready as well