laminas / laminas-cli

Console command runner, exposing commands written in Laminas MVC and Mezzio components and applications
https://docs.laminas.dev/laminas-cli
BSD 3-Clause "New" or "Revised" License
55 stars 22 forks source link

Normalize composer #72

Closed ghostwriter closed 3 years ago

ghostwriter commented 3 years ago

[QA]

ghostwriter commented 3 years ago

yes, I was made aware, my conversation with froschdesign that is why i made a PR in each repo on all 3 organizations.

consistent "Normalized" format.

froschdesign commented 3 years ago

yes, I was made aware, my conversation with froschdesign that is why i made a PR in each repo on all 3 organizations.

But I never said that implementation was necessary or wanted. A previous discussion would have been helpful for all sides.

ghostwriter commented 3 years ago

But I never said that implementation was necessary or wanted. A previous discussion would have been helpful for all sides.

Correct, i was only talking about the need for a "consistent format". (2 quotes below)

The problem is that inconsistencies arise between the repositories which can be result in more work or other problems. And with more than 180 repositories in 3 different GitHub organizations, nobody needs that.

We tried to "normalize" composer.json during the migration from ZF and then we agreed consistent format.

I may have misunderstood something. I thought i was fixing the inconsistencies issue that hindered this orgs from completing this task during the initial migration from ZF, by adding the QA checks via laminas/laminas-continuous-integration-action#38 & laminas/laminas-ci-matrix-action#32 and sending each repo a PR with the necessary changes.

weierophinney commented 3 years ago

Please open an RFC with the Technical Steering Committee before creating batched pull requests. This is requested so as to: