continous integration with psalm

laminas / laminas-component-installer

Composer plugin for injecting modules and configuration providers into application configuration

https://docs.laminas.dev/laminas-component-installer/

BSD 3-Clause "New" or "Revised" License

27 stars 12 forks source link

continous integration with psalm #26

Closed boesing closed 3 years ago

boesing commented 3 years ago

Q	A
QA	yes

Description

Introducing GHA CI workflow. As I've added composer.lock to the repository, psalm started to argue about the project. I've started to fix stuff with adding additional types but at some point, I had to change property defaults, e.g. (which are added by __construct or replaced by upstream classes).

As this package is not meant to be extended in userland code, I'd say those BC breaks (changes of annotations, e.g.) may be fine.

Thoughts?

Ping @Ocramius @weierophinney

weierophinney commented 3 years ago

@boesing I agree - this is not a package for extension, but one for consumption as a plugin.

I've made some additional changes to the PR:

s/continous/continuous/ - I make the same mistake in spelling all the time. :rofl:
I've configured some "additional_checks" and a pre-run script so that we can:
- Test PHP 7.4 and 8.0 against Composer v1 releases
- Keep the existing license docheader check (not sure if it's needed, but this is a great way to demonstrate adding such a check)

At this point, only the Psalm checks are failing.

weierophinney commented 3 years ago

Psalm checks were only failing due to the unwritable cache directory (I think this is something new on their end; I'd not run into it until this week, and now it's failing everywhere until I add the cacheDirectory configuration to the psalm.xml.dist file; the --no-cache flag does not affect it, unfortunately). With a cacheDirectory configured, they run, so I'm going to consider this complete.