Add type cast to prevent deprecated passing of null value to is_dir

laminas / laminas-component-installer

Composer plugin for injecting modules and configuration providers into application configuration

BSD 3-Clause "New" or "Revised" License

27 stars 12 forks source link

Closed arueckauer closed 2 years ago

arueckauer commented 2 years ago

Q	A
QA	yes

This fixes the deprecated call of is_dir with a null value by casting input value for strict comparison with empty string.

See #36.

arueckauer commented 2 years ago

After some explanation from @boesing I have a better understanding of the issue and close this in favor of #40 .

boesing commented 2 years ago

Summary form another chat:

the composer plugin class ComponentInstaller has a property projectRoot (link) supposed to be string but is actually null due to a check within __construct (link)
so projectRoot can be null when its passed to the config discovery
this will be passed to the AbstractDiscovery#__construct which then passes it to is_dir (link)

(this was btw detected by psalm already but we’ve passed it to the baseline - no front here!)