search

laminas / laminas-component-installer

Composer plugin for injecting modules and configuration providers into application configuration
https://docs.laminas.dev/laminas-component-installer/
BSD 3-Clause "New" or "Revised" License
27 stars 12 forks source link

Forward compatibility for composer v2.3.6+ #51

Closed boesing closed 2 years ago

boesing commented 2 years ago
Q A
QA yes

Description

To avoid deprecation messages with composer v2.3.6 and above, we follow the deprecation messages suggestion and use RepositoryFactory#defaultReposWithDefaultManager instead of RepositoryFactory#defaultRepos.

fixes #47

Ocramius commented 2 years ago

Would it make sense to declare ^2.4 compat when it's out? 🤔

boesing commented 2 years ago

Would it make sense to declare ^2.4 compat when it's out? 🤔

I was thinking about this as well. But since I know that in CI pipelines (even in ours) are not always the latest and greatest composer versions, this might be kinda annoying for some projects. Since I do prefer not blocking too many projects from updating to the next major, I think its fine for now to use the method_exists check.

WDYT?

Ocramius commented 2 years ago

Works for me - dependency requirement can be bumped later.