laminas / laminas-continuous-integration-action

GitHub Action for running a QA check
BSD 3-Clause "New" or "Revised" License
19 stars 19 forks source link

Update dependency markdownlint-cli2 to v0.12.1 #133

Closed renovate[bot] closed 9 months ago

renovate[bot] commented 2 years ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
markdownlint-cli2 0.3.2 -> 0.12.1 age adoption passing confidence

Release Notes

DavidAnson/markdownlint-cli2 (markdownlint-cli2) ### [`v0.12.1`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#0121) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.12.0...v0.12.1) - Update JSONC parsing to handle trailing commas - Add documentation links to JSON schema - Update dependencies ### [`v0.12.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#0120) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.11.0...v0.12.0) - Remove deprecated `markdownlint-cli2-config` entry point - Use `markdownlint-cli2 --config ...` instead - Remove deprecated `markdownlint-cli2-fix` entry point - Use `markdownlint-cli2 --fix ...` instead - Add `--help` and `--no-globs` parameters - Improve and document included JSON schemas - Update dependencies (including `markdownlint`) ### [`v0.11.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#0110) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.10.0...v0.11.0) - Add `modulePaths` configuration option - Update dependencies (including `markdownlint`) - Remove support for end-of-life Node 16 ### [`v0.10.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#0100) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.9.2...v0.10.0) - Add `showFound` configuration option - Add `.markdownlint-cli2.jsonc` config schema - Update dependencies (including `markdownlint`) ### [`v0.9.2`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#092) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.9.1...v0.9.2) - Remove `npm-shrinkwrap.json` entirely to avoid `npm` failures ### [`v0.9.1`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#091) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.9.0...v0.9.1) - Remove `devDependencies` from `npm-shrinkwrap.json` to avoid `npm` failures ### [`v0.9.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#090) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.8.1...v0.9.0) - Add support for Node.js's `package.json` as a configuration file source - Add output formatter for Static Analysis Results Interchange Format/SARIF - Bundle `npm-shrinkwrap.json` for reproducible/faster installs - Update dependencies (including `markdownlint`) ### [`v0.8.1`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#081) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.8.0...v0.8.1) - Handle `--config` edge case ### [`v0.8.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#080) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.7.1...v0.8.0) - Add support for `--config` and `--fix` parameters - Update dependencies (including `markdownlint`) - Remove support for end-of-life Node 14 ### [`v0.7.1`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#071) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.7.0...v0.7.1) - Update dependencies (including `markdownlint`) ### [`v0.7.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#070) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.6.0...v0.7.0) - Add support for `extends` in `config` property of `.markdownlint-cli2.*` files - Build and publish `davidanson/markdownlint-cli2-rules` Docker container image - Update dependencies (including `markdownlint`) ### [`v0.6.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#060) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.5.1...v0.6.0) - Update dependencies (including `markdownlint`) ### [`v0.5.1`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#051) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.5.0...v0.5.1) - Update dependencies ### [`v0.5.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#050) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.4.0...v0.5.0) - New rules - Support modules (MJS) everywhere - Include dotfiles ### [`v0.4.0`](https://togithub.com/DavidAnson/markdownlint-cli2/blob/HEAD/CHANGELOG.md#040) [Compare Source](https://togithub.com/DavidAnson/markdownlint-cli2/compare/v0.3.2...v0.4.0) - New rules - Async custom rules - Explicit config - CJS (breaking)

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

β™» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.



Read more information about the use of Renovate Bot within Laminas.

Ocramius commented 2 years ago

Unsure about this one: if it turns out to be a BC break, we may need to defer it.

The tags convey zero upgrade/change notes.

Therefore poked @froschdesign about a decision here.

Build also failed related to this dependency upgrade:

 #0 2.777 found 0 vulnerabilities
#0 2.869 internal/modules/cjs/loader.js:818
#0 2.869   throw err;
#0 2.869   ^
#0 2.869 
#0 2.869 Error: Cannot find module 'node:path'
#0 2.869 Require stack:
#0 2.869 - /markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js
#0 2.869     at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
#0 2.869     at Function.Module._load (internal/modules/cjs/loader.js:667:27)
#0 2.869     at Module.require (internal/modules/cjs/loader.js:887:19)
#0 2.869     at require (internal/modules/cjs/helpers.js:74:18)
#0 2.869     at Object.<anonymous> (/markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js:13:14)
#0 2.869     at Module._compile (internal/modules/cjs/loader.js:999:30)
#0 2.869     at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
#0 2.869     at Module.load (internal/modules/cjs/loader.js:863:32)
#0 2.869     at Function.Module._load (internal/modules/cjs/loader.js:708:14)
#0 2.869     at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
#0 2.869   code: 'MODULE_NOT_FOUND',
#0 2.869   requireStack: [
#0 2.869     '/markdownlint/node_modules/markdownlint-cli2/markdownlint-cli2.js'
#0 2.869   ]
#0 2.869 }
#17 ERROR: process "/bin/sh -c cd /markdownlint     && npm ci     && node_modules/.bin/markdownlint-cli2 /test-files/dummy-ok-markdown-test-file.md     && if node_modules/.bin/markdownlint-cli2 /test-files/dummy-ko-markdown-test-file.md; then exit 1; else exit 0; fi" did not complete successfully: exit code: 1
froschdesign commented 2 years ago

Looks like we will have to wait here: https://github.com/DavidAnson/markdownlint-cli2/issues/72

internalsystemerror commented 1 year ago

That issue was fixed in v0.6.0 which this PR wants to merge to, however that requires "nodejs": ">=14.18.0" and we're installing v12 from apt in the container.

https://github.com/laminas/laminas-continuous-integration-action/blob/a39482668bb41479b0c8f8cdd2a3369e5a0c8628/Dockerfile#L71

We could install this using NodeSource instead?

internalsystemerror commented 1 year ago

It's still installing node v12 πŸ€” . I wonder if we need to run apt update again AFTER we add the nodesource repository. I'll investigate.

internalsystemerror commented 1 year ago

I've double checked and I get v20.2.0 installed inside the container even without running apt-update:

root@e6764e78a92d:/# node -v v20.2.0 root@e6764e78a92d:/# npm -v 9.6.6

So I'm not sure why it shows as having an old version of node https://github.com/laminas/laminas-continuous-integration-action/actions/runs/5157663786/jobs/9290364177?pr=133#step:6:2116

Edit: Do we need to release the changes on 1.33 first, in order for this to succeed?

internalsystemerror commented 1 year ago

I believe I found the issue, I'd missed the fact that markdownlint has its own docker stage. https://github.com/laminas/laminas-continuous-integration-action/pull/156 should address this.

internalsystemerror commented 1 year ago

Its still showing as having node v12 installed ... I'm at a loss where that is coming from as it has everything it needs for v20 and when I run the container locally I get the output as above, v20 installed.