Add PHP 8.3 support for sqlsrv extension

laminas / laminas-continuous-integration-action

GitHub Action for running a QA check

BSD 3-Clause "New" or "Revised" License

19 stars 19 forks source link

Add PHP 8.3 support for sqlsrv extension #211

Closed MauricioFauth closed 9 months ago

MauricioFauth commented 9 months ago

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	no

Description

As this is a beta release, it should not be used for PHP 8.1 and 8.2.

Fixes #204

https://github.com/microsoft/msphpsql/releases/tag/v5.12.0-beta1

Xerkus commented 9 months ago

I think sqlsrv release archives should be updated to use ubuntu22 variant to match ci container.

boesing commented 9 months ago

are these available? then id say yes. I wonder if there is a way to have that Ubuntu version get parsed to not have to manually update a bunch of files.

Xerkus commented 9 months ago

are these available? then id say yes. I wonder if there is a way to have that Ubuntu version get parsed to not have to manually update a bunch of files.

It is highly dependent on what files are uploaded to sqlsrv github release. No need for special parsing imo.

Xerkus commented 9 months ago

Can someone verify extension actually works on 8.3?

Xerkus commented 9 months ago

@MauricioFauth thank you