search

laminas / laminas-continuous-integration-action

GitHub Action for running a QA check
BSD 3-Clause "New" or "Revised" License
19 stars 19 forks source link

Infection always fails if you want pcov installed #91

Open gsteel opened 2 years ago

gsteel commented 2 years ago

Bug Report

Q A
Version(s) latest

Summary

If you have pcov setup as an extension and you've also got infection setup, the infection run dies on sig 11.

Removing pcov as a required extension makes infection run normally - I guess pcov and phpdbg don't play nicely together.

If you need pcov for you project, this is a bit of pain because you can't opt-out of the infection run and write your own workflow without phpdbg because the run is triggered by the infection.json file.

In my case, I'm just gonna make do without pcov. Perhaps this is just a documentation issue. If so, it wold also be worth providing some helpful setup pointers for infection configuration WRT running this action successfully.

Ocramius commented 2 years ago

Which project experiences this? I use pcov for MT all the time 🤔

gsteel commented 2 years ago

It was this pull on a WIP pet project - I had infection running fine in my own workflows with pcov, but dropped them in favour of laminas-ci. Removing pcov from laminas-ci.json fixed the segfaults so it's just my assumption that the combination of pcov/phpdbg was the problem

Ocramius commented 2 years ago

Crash @ https://github.com/gsteel/listless/runs/6182805668?check_suite_focus=true#step:3:427

I think pcov, xdebug and phpdbg should be able to coexist regardless: probably best to raise this in infection/infection and ask for further guidance there, than just dropping the dependency here.