search

laminas / laminas-crypt

Strong cryptography tools and password hashing
https://docs.laminas.dev/laminas-crypt/
BSD 3-Clause "New" or "Revised" License
39 stars 24 forks source link

Add PHP 8.0 support, require PHP 7.3 or newer #11

Closed bfoosness closed 3 years ago

bfoosness commented 3 years ago
Q A
New Feature yes

Description

Close #10

glensc commented 3 years ago

As you changed requirements with the changes in this PR, can you fill such details to PR body?

bfoosness commented 3 years ago

Thanks, I'll take a look today. In the meantime, https://github.com/laminas/laminas-math/pull/5 is a blocker and I think it's ready to go.

weierophinney commented 3 years ago

@bfoosness I've rebased your branch off the new 3.4.x branch, which contains our GHA CI workflow, and pushed the changes back; make sure you pull!

Because I rebased... I'm not sure if you've incorporated all feedback yet. Can you drop me a note and let me know?

bfoosness commented 3 years ago

@weierophinney: Thank you! I believe https://github.com/laminas/laminas-crypt/pull/11#pullrequestreview-570228562 was the only outstanding issue, and it's related to the conversation at https://github.com/laminas/laminas-crypt/pull/11#discussion_r541582468

I couldn't reproduce these failures locally, and the tests now appear to pass with the GHA CI workflow.