laminas / laminas-crypt

Strong cryptography tools and password hashing
https://docs.laminas.dev/laminas-crypt/
BSD 3-Clause "New" or "Revised" License
39 stars 24 forks source link

Adds previously dynamic properties for PHP 8.2 compatibility #26

Closed gsteel closed 1 year ago

gsteel commented 1 year ago

At the moment, laminas-filter needs this for it's CI to pass. See

https://github.com/laminas/laminas-filter/pull/90

and one of the run failures here

https://github.com/laminas/laminas-filter/actions/runs/3717446853/jobs/6304805223

Ocramius commented 1 year ago

CI errors seem to be related with OpenSSL no longer supporting certain operations: unsure how to proceed here :thinking:

gsteel commented 1 year ago

Maybe it'd be easier to drop the encryption adapters from laminas-filter and release a major?

Ocramius commented 1 year ago

@gsteel how about:

  1. deprecating them
  2. removing their tests too

That would give some space for moving forward, whilst preventing a major (for now)

gsteel commented 1 year ago

Closing this PR because the problem with laminas-filter is now solved