laminas / laminas-crypt

Strong cryptography tools and password hashing
https://docs.laminas.dev/laminas-crypt/
BSD 3-Clause "New" or "Revised" License
39 stars 24 forks source link

Dependency of `laminas/laminas-servicemanager` can be removed #27

Closed boesing closed 1 month ago

boesing commented 1 year ago

Feature Request

Q A
BC Break no

Summary

Hey there, I realized that this component still depends on servicemanager while it provides its own ContainerInterface implementation.

github-actions[bot] commented 1 year ago

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee. If you have a security issue, please follow our security reporting guidelines. If you wish to take on the role of maintainer, please nominate yourself

Ocramius commented 1 year ago

This one?

https://github.com/laminas/laminas-crypt/blob/56ab1b195dad5456753601ff2e8e3d3fd9392d1a/src/Symmetric/PaddingPluginManager.php#L17

Yep, we can drop the dependency :+1:

Note that upgrading to psr/container:^2 is trickier, because the implementations are not final

gsteel commented 1 month ago

Closed via #33