PHP 8.3 support added - Githubissues

laminas / laminas-crypt

Strong cryptography tools and password hashing

https://docs.laminas.dev/laminas-crypt/

BSD 3-Clause "New" or "Revised" License

39 stars 24 forks source link

PHP 8.3 support added #31

Closed glo71317 closed 10 months ago

glo71317 commented 11 months ago

Q	A
Documentation	yes/no
Bugfix	yes/no
BC Break	yes/no
New Feature	yes/no
RFC	yes/no
QA	yes/no

Description

glo71317 commented 11 months ago

It seems some issue with infrastructure,

The error is typically caused by one of the following reasons: An outdated or incompatible version of Node.js or OpenSSL is installed on your system. @Ocramius Can you please help regarding this how to proceed on this?

glo17680 commented 10 months ago

@Ocramius Is there any update on the infrastructure fixes on this PR. Can you please advise ?

froschdesign commented 10 months ago

@glo17680 There are many simple problems that can be solved. For example:

1) LaminasTest\Crypt\BlockCipher\OpensslAeadTest::testEncryptDecrypt with data set #0 ('gcm') Creation of dynamic property LaminasTest\Crypt\BlockCipher\OpensslAeadTest::$blockCipher is deprecated 1) phpunit.xml.dist validates 61) LaminasTest\Crypt\PublicKey\RsaTest::testVerifyCorruptRaw Creation of dynamic property LaminasTest\Crypt\PublicKey\RsaTest::$privateKey is deprecated

Any help with this is welcome!

froschdesign commented 10 months ago

@glo71317 @glo17680 Please see the following pull requests for more information on this package:

glo71317 commented 10 months ago

@glo71317 @glo17680 Please see the following pull requests for more information on this package:

Allow php 8.3, migrate to phpunit 10 #32

Add abandonment of laminas-crypt to the agenda technical-steering-committee#155

As per above details this PR is irrelevant now right?

weierophinney commented 10 months ago

I pulled your branch locally, and was able to resolve all test failures:

Changing the algorithm used for factory and set*Algorithm() tests to use AES instead of Blowfish (which has been removed from recent editions of OpenSSL).
Using a MUCH larger prime for DH tests (I grabbed one from the PHP manual).

It looks like we get failures on PHP 8.0, however; I'll see if I can resolve those.

weierophinney commented 10 months ago

Failures on PHP 8 were due to some algorithms being unsupported in OpenSSL 3; I've updated tests to skip those algorithms if that version of the library is present.