search

laminas / laminas-crypt

Strong cryptography tools and password hashing
https://docs.laminas.dev/laminas-crypt/
BSD 3-Clause "New" or "Revised" License
39 stars 24 forks source link

Replace `container-interop/container-interop` #7

Closed mlapkin closed 3 years ago

mlapkin commented 4 years ago

Replace deprecated container-interop/container-interop with psr/container.

djozsef commented 4 years ago

@michalbundyra can we let this PR throught? The test case fails due to an AES CCM tag length setting problem. This problem has nothing to do with Interop\Container\ContainerInterface usage defined by container-interop/container-interop. As far as my research went.

michalbundyra commented 4 years ago

@djozsef

The test case fails due to an AES CCM tag length setting problem. This problem has nothing to do with Interop...

Can you clarify please what do you mean? What is the problem and why do you wan to get this merged if the problem is somewhere else? Thanks.

djozsef commented 4 years ago

@michalbundyra Sorry I missed some valid BC breaking changes in the PR, that's why I thought it can be merged. NVM.

Regarding the AES CCM tag length problem my best bet is that when encrypting the tag length has to be calculated as an exponent of 2. See 24 here.

weierophinney commented 3 years ago

This package is considered feature-complete, and is now in security-only maintenance mode, following a decision by the Technical Steering Committee. If you have a security issue, please follow our security reporting guidelines. If you wish to take on the role of maintainer, please nominate yourself

Ocramius commented 2 years ago

See #20 for a better future-proof plan.