search

laminas / laminas-db

Database abstraction layer, SQL abstraction, result set abstraction, and RowDataGateway and TableDataGateway implementations
https://docs.laminas.dev/laminas-db/
BSD 3-Clause "New" or "Revised" License
119 stars 66 forks source link

Adjust documented return types to be `$this` where the pre-existing `self` declaration was too imprecise #244

Closed InvisibleSmiley closed 2 years ago

InvisibleSmiley commented 2 years ago

Obvious fix.

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #233: Predicate methods claim to return self (actually: $this or static)

Ocramius commented 2 years ago

Obvious fix.

The commit message is everything but obvious though: could you please rebase + reword it to explain what is being done, for future log readers?

Ocramius commented 2 years ago

Actually, the merge commit should be clear enough, as per rephrasing just now