laminas / laminas-developer-tools

Module for developer and debug tools for use with laminas-mvc applications.
BSD 3-Clause "New" or "Revised" License
23 stars 13 forks source link

In HTML5, the <head> element can be omitted. The zend-developer-tools css requires it. #1

Closed weierophinney closed 3 years ago

weierophinney commented 4 years ago

Provide a narrative description of what you are trying to accomplish.

Code to reproduce the issue

In HTML5, the <head> element can be omitted. The following code will validate as HTML5:

<!DOCTYPE html>
<html>
<title>Title of the document</title>

<body>
<h1>This is a heading</h1>
<p>This is a paragraph.</p>
</body>

</html>

However, ZendDeveloperTools\Listener->injectToolbar() requires it to work

$injected = preg_replace('/<\/head>/i', $style . "\n</head>", $injected, 1);

Expected results

Styles should be displayed in the html document even if there is no <head> html element when the document is html 5 document.

Actual results

html document does not include zend-developer-tools required css, if <head> element is missing from the layout.


Originally posted by @villetikkanen at https://github.com/zendframework/zend-developer-tools/issues/255

samsonasik commented 3 years ago

@villetikkanen I've created PR https://github.com/laminas/laminas-developer-tools/pull/31 for it.