laminas / laminas-developer-tools

Module for developer and debug tools for use with laminas-mvc applications.
BSD 3-Clause "New" or "Revised" License
23 stars 13 forks source link

Feature: CSS Markup #19

Open weierophinney opened 4 years ago

weierophinney commented 4 years ago

Would it be possible to add all the CSS Markup into a CSS File so that when you view the source in a browser you don't have to scroll to find your code?

Right now I have to scroll past all the ZDT CSS Markup in the source to look at my own source and it can be quite annoying at times.


Originally posted by @diemuzi at https://github.com/zendframework/zend-developer-tools/issues/118

weierophinney commented 4 years ago

@diemuzi the idea is to make everything in a single HTTP request. That's the good/bad part of the toolbar.


Originally posted by @Ocramius at https://github.com/zendframework/zend-developer-tools/issues/118#issuecomment-21627969

weierophinney commented 4 years ago

Hrmm... Perhaps a flag that we can set to either make it a single request or file based?

OR

Perhaps the CSS can be loaded at the end of the page? That would be fine too actually =)


Originally posted by @diemuzi at https://github.com/zendframework/zend-developer-tools/issues/118#issuecomment-21628174

weierophinney commented 4 years ago

@diemuzi using a custom CSS placeholder that collects all of the CSS from the various toolbar components would be fine.


Originally posted by @Ocramius at https://github.com/zendframework/zend-developer-tools/issues/118#issuecomment-21628931

weierophinney commented 4 years ago

move style to body: (http://stackoverflow.com/questions/2830296/using-style-tags-in-the-body-with-other-html)

view/zend-developer-tools/toolbar/style.phtml, Line 2: < style type="text/css" media="screen" scoped>

src/ZendDeveloperTools/Listener/ToolbarListener.php, Lines 161-162: $injected = preg_replace('/<\/body>/i', $style . $toolbar . "\n< / body>", $response->getBody(), 1); //$injected = preg_replace('/<\/head>/i', $style . "\n", $injected, 1);


Originally posted by @oliverkoenig at https://github.com/zendframework/zend-developer-tools/issues/118#issuecomment-34349850