search

laminas / laminas-di

Automated dependency injection for PSR-11 containers
https://docs.laminas.dev/laminas-di/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

Custom logger #11

Closed waahhhh closed 4 years ago

waahhhh commented 4 years ago
Q A
Documentation yes
Bugfix maybe
BC Break no
New Feature yes
RFC no
QA yes

Description

first commit: I have sorted the code lines of the GeneratorFactory for the reason: put together what belongs together.

second commit (the primary reason): The code generator can accept a logger. See: https://docs.laminas.dev/laminas-di/codegen/#logging. The default logger is \Psr\Log\NullLogger. Currently you can't configure a logger. I would like to get the ability to configure a logger.

waahhhh commented 4 years ago

The documentation has been improved. I also fixed the failing unit test that was broken on the branch develop.

tux-rampage commented 4 years ago

Thank you very much @waahhhh I'm just checking back with the technical steering comitee before merging this.

tux-rampage commented 4 years ago

@michalbundyra lgtm, can you confirm that your feedback is properly adressed?