search

laminas / laminas-di

Automated dependency injection for PSR-11 containers
https://docs.laminas.dev/laminas-di/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

Fix handling of aot namespace config #12

Closed tux-rampage closed 4 years ago

tux-rampage commented 4 years ago
Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

When the AoT namespace is an empty array, it will bypass an expected exception that should reveal a misconfiguration issue. This was revealed by a failing test case.

This failing test only affects the developbranch.

See #11 and #10

tux-rampage commented 4 years ago

@michalbundyra Thanks for reviewing :+1:

I'll rephrase the Changelog. Could rephrasing the Exception message with a Link to this PR be helpful?

tux-rampage commented 4 years ago

@michalbundyra This is affecting a fix for a pending feature introduced with https://github.com/zendframework/zend-di/pull/51 - which is not yet released. Therefore no one should be affected unless they explicitly require ^3.2@dev or dev-develop - In this case I'd consider users to be aware of potential breaks.

Maybe we can drop the Changelog-Entry entirely? What do you think?

michalbundyra commented 4 years ago

@tux-rampage yes, if the issue is present only on develop we can drop the changelog (unless some behaviour has been changed previously and it was not noted in changelog?)

tux-rampage commented 4 years ago

... (unless some behaviour has been changed previously and it was not noted in changelog?)

No this is not the case. It was introduced with a completely new feature (new delegator factory that did not exist before). So this actually finishes the feature from PR zendframework/zend-di#51 listed in the changelog under 3.2.0 (currently TBD).