Migrate to laminas/laminas-coding-standard v2

laminas / laminas-di

Automated dependency injection for PSR-11 containers

https://docs.laminas.dev/laminas-di/

BSD 3-Clause "New" or "Revised" License

36 stars 20 forks source link

Migrate to laminas/laminas-coding-standard v2 #16

Closed gennadigennadigennadi closed 3 years ago

gennadigennadigennadi commented 3 years ago

Q	A
Bugfix	yes
QA	yes

Description

Started working on migration Code style to v2.

tux-rampage commented 3 years ago

There are duplicate remarks, github was not showing them anymore after I temporarly navigated away from the review :facepalm: sorry about that.

The builds are failing for PHP 7.1 which is IMHO not a big deal - it's EOL anyways.

I'd suggest to wait for PR #15 (which is almost ready) to be merged since this PR must be rebased anyways afterward.

tux-rampage commented 3 years ago

@gennadigennadigennadi thanks for your patience. I've merged #15, could you please rebase your branch on 3.2.x and address the feedback? :v:

gennadigennadigennadi commented 3 years ago

I rebased yesterday and I am going to work the next few days on the feedback.

boesing commented 3 years ago

LGTM aswell. I definitely was wrong with that nullable flag. I was totally convinced it introduces BC break but it doesn't. Sorry for bothering you two...