search

laminas / laminas-di

Automated dependency injection for PSR-11 containers
https://docs.laminas.dev/laminas-di/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

CLASS DEFINITION: Update documentation & remove unreported errors #51

Closed sjokkateer closed 2 years ago

sjokkateer commented 2 years ago

Signed-off-by: Remy Bos 27890746+sjokkateer@users.noreply.github.com

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

This PR updates and fixes the ClassDefinition::class' dockblock's type declrations and the return types of two private methods. Additionally, unreported errors have been removed from phpstan-baseline.

sjokkateer commented 2 years ago

I was additionally wondering if changing ClassDefinition::reflectParameters()'s comparison function to using the spaceship operator would provide any benefits, or leave it as is?

Ocramius commented 2 years ago

I was additionally wondering if changing ClassDefinition::reflectParameters()'s comparison function to using the spaceship operator would provide any benefits, or leave it as is?

IMO leave as-is: risky change for little benefit