laminas / laminas-di

Automated dependency injection for PSR-11 containers
https://docs.laminas.dev/laminas-di/
BSD 3-Clause "New" or "Revised" License
36 stars 20 forks source link

PHPBENCH: Add a benchmark test suite #65

Closed sjokkateer closed 2 years ago

sjokkateer commented 2 years ago

Signed-off-by: Remy Bos 27890746+sjokkateer@users.noreply.github.com

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA yes

Description

This PR adds a small benchmark test suite to the project.

sjokkateer commented 2 years ago

This installs the tooling, but none of the benchmarks :D

Need at least one code path to be verified by a benchmark (ideally the code path from #64 ? )

Yes :P I'll get back to the two open PRs on laminas-di soon!

Ocramius commented 2 years ago

Thanks, wasn't sure if I had missed something :+1:

sjokkateer commented 2 years ago

@Ocramius What do you think of the added benchmark tests for testing #64 ?

sjokkateer commented 2 years ago

@Ocramius Cool, thanks for your time and review. I'll get back to resolving the things you mentioned later today!