Update to `laminas/laminas-coding-standard:2.3.x`, improved types and internal API

laminas / laminas-diactoros

PSR HTTP Message implementations

https://docs.laminas.dev/laminas-diactoros/

BSD 3-Clause "New" or "Revised" License

483 stars 63 forks source link

Update to `laminas/laminas-coding-standard:2.3.x`, improved types and internal API #103

Closed gsteel closed 2 years ago

gsteel commented 2 years ago

Q	A
QA	yes

Description

Does the donkey work upgrading to LCS 2.3

Changes to tests and src are in separate commits

gsteel commented 2 years ago

@Ocramius … Integration tests are failing on 8.0 and 8.1 at https://github.com/laminas/laminas-diactoros/blob/c1a61118c23a8b996082e51a3c31a07f7f7107a5/src/Stream.php#L339

I think this is because an empty path is throwing a ValueError in fopen - In order to fix this failure, we'll need to explicitly check for the empty path and throw the expected exception right?

gsteel commented 2 years ago

OK, I take that last comment back - for some reason, the error handler is being ignored on 8.0 and 8.1 - this is all stuff that hasn't been touched by this PR so I'm a little bit confused as to why CI would be failing here…

Ocramius commented 2 years ago

Ah, I did not notice the failures. I have another branch where I did this, and will propose a patch :thinking:

Ocramius commented 2 years ago

Opened #104 - unsure if failures are comparable