Closed markstory closed 2 years ago
/cc @froschdesign for getting guidance on the docs section
BTW, overall direction of this patch is good :+1:
I've resolved all but one of psalm's complaints. The remaining MixedArgumentTypeCoercion was added to the baseline file beside the existing one in the same method.
Went through it again: I know most code is just transposed as-is, so we're good here.
Releasing 🚢
Description
This method will provide a public API to create Uri instances from SERVER context. This helps libraries that depend on diactoros and have their own ServerRequest or Uri implementations use the logic in diactoros more efficiently.
I wanted to get a rough draft of this up for feedback. If it is headed in the right direction, I have a few TODOs remaining:
factories
section, but would appreciate any direction here.If there are other requirements that need to be met let me know :smile:
Refs #122