Add support for PHP 8.4

laminas / laminas-diactoros

PSR HTTP Message implementations

https://docs.laminas.dev/laminas-diactoros/

BSD 3-Clause "New" or "Revised" License

487 stars 63 forks source link

Add support for PHP 8.4 #191

Closed cedric-anne closed 2 months ago

cedric-anne commented 2 months ago

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	yes
RFC	no
QA	no

cedric-anne commented 2 months ago

There are the following deprecations triggered by any PHP command in the CI env itself:

PHP Deprecated:  session.sid_length INI setting is deprecated in Unknown on line 0
PHP Deprecated:  session.sid_bits_per_character INI setting is deprecated in Unknown on line 0

For instance, they are triggered inside the CI init process itself:

I do not know how to fix them, and it makes the PHPUnit test failing.

gsteel commented 2 months ago

An upgrade to PHPUnit 10 is probably required - see #190

cedric-anne commented 2 months ago

An upgrade to PHPUnit 10 is probably required - see #190

Honestly, I thought it would take me only a few minutes at first. I proposed this to be able to activate PHP 8.4 checks on the CI of a dependency of a dependency we use. Unfortunately, I will not have time to investigate more on this right now.

cedric-anne commented 2 months ago

I have no idea how to fix tests and no time to investigate on this. I close this PR as I am pretty sure I will not be able to finish it.