search

laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications
https://docs.laminas.dev/laminas-diagnostics/
BSD 3-Clause "New" or "Revised" License
55 stars 32 forks source link

PHP 8.0 support #15

Closed arueckauer closed 3 years ago

arueckauer commented 3 years ago
Q A
Documentation no
Bugfix no
BC Break yes/no
New Feature no
RFC no
QA yes

Description

This PR provides provides changes described in #12.

Fixes #12

arueckauer commented 3 years ago

Hi @boesing 👋🏻

It seems Travis configuration needs some update for PHP nightly builds. I am unsure how to fix that. Has this issue been solved in another component where PHP 8 support has been added?

boesing commented 3 years ago

Hm, when I understand this correct, its because of the TESTS_LAMINAS_DIAGNOSTICS_APCU_ENABLED global environment var.

We should install apcu 5.1.19 as it is compatible with PHP 8.0. You can have a look at laminas-cache-storage-adapter-apcu to see how to install pecl extensions during CI.

arueckauer commented 3 years ago

Thanks for the input. APCu now works.

Since Memcached is not yet supported for PHP 8.0 (see latest version 3.1.5), I disabled it.

For MongoDB I added the 1.9.0RC1 which adds support for PHP 8. Unfortunately the build was not executed, due to a negative credit balance in Travis.

Owner laminas does not have enough credits.

boesing commented 3 years ago

Thanks for the changes. We might want to have a look when travis is back up and running. 👍

arueckauer commented 3 years ago

@boesing Builds are generally running again, but the latest push did not trigger Travis. Can you manually start the build process?

mathieupetrini commented 3 years ago

Hi,

https://github.com/bovigo/vfsStream/pull/232 has been merged. Is it possible to restart failing jobs ?

samsonasik commented 3 years ago

restarted

weierophinney commented 3 years ago

I've taken the liberty of amending this with changes to the CI pipeline. We're moving off of Travis to GHA, and I plan to provide fixes per the feedback provided already... but we're out of Travis minutes for the month, so first step is getting a working CI pipeline. :smile:

As you can see, all green at this stage, and we have tests against all expected services.

Ocramius commented 3 years ago

We're moving off of Travis to GHA

@weierophinney the GHA setup used here seems to be a bit wonky, but in the interest of getting anything running at this point, I would say :ship: