laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications
https://docs.laminas.dev/laminas-diagnostics/
BSD 3-Clause "New" or "Revised" License
55 stars 32 forks source link

Update to laminas-coding-standard v2 series #39

Closed weierophinney closed 2 years ago

weierophinney commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This patch updates to laminas-coding-standard v2, with the exception of the declare(strict_types=1) requirement.

A few comparisons were updated to use strict equality, but only where the other value type was known; tests continue to run locally.

Ocramius commented 2 years ago

Uhhh, this should NOT be in a patch release :|

Ocramius commented 2 years ago

Will reset 1.14.x to a state before this patch. Sorry, @weierophinney, but I want to avoid another https://github.com/laminas/laminas-db/issues/241

Ocramius commented 2 years ago

1.14.x is now rolled back at 1.14.0 state. #36 covers these changes in 1.15.x.

I decided to not revert this, but rather have a full history rollback, because otherwise a merge-up from 1.14.x to 1.15.x would be a disaster.