search

laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications
https://docs.laminas.dev/laminas-diagnostics/
BSD 3-Clause "New" or "Revised" License
55 stars 32 forks source link

Allow PHP 8.2, drop PHP 7 support #55

Closed IonBazan closed 1 year ago

IonBazan commented 1 year ago

Signed-off-by: Ion Bazan ion.bazan@gmail.com

Q A
Documentation /no
Bugfix no
BC Break no
New Feature no
RFC no
QA no

Description

Allowing PHP 8.2 in composer.json and build matrix.

Tests failing because some php8.2-* extensions are not available in https://launchpad.net/~ondrej/+archive/ubuntu/php/ PPA yet.

Ocramius commented 1 year ago

This should be re-tried: the newer versions of CI include a bunch of 8.2 tooling now.

Ocramius commented 1 year ago

Hmm, MongoDB missing is a bit of a pain, at this stage: will probably need to wait until after PHP 8.2 is released in Ondrej's PPAs.

IonBazan commented 1 year ago

@Ocramius tests were failing because DiskFree::$path was set dynamically - solved by adding it there but Psalm is still complaining about some unrelated stuff. I suggest fixing that in a separate PR.

samsonasik commented 1 year ago

You can fix with run : 

composer cs-fix

Psalm need fixing as well https://github.com/laminas/laminas-diagnostics/actions/runs/3728718218/jobs/6323968842#step:4:506

IonBazan commented 1 year ago

Thanks @samsonasik - forgot to run that before pushing. Regarding Psalm errors, I'll try to fix that in a separate PR to keep the changes scoped.

Ocramius commented 1 year ago

The remaining psalm issues are something I fixed in #62, but no time to pursue that further right now.

I suggest re-generating the baseline: please make sure you do so from a compatible environment (docker run --rm -ti -v $(pwd):/app -w /app php:8.0 bash may help)

IonBazan commented 1 year ago

Thanks for the tips, @Ocramius - turned out I had to pass --set-baseline=psalm-baseline.xml too to add new entries. CI is green now ✅