Add responsetime/uptime/connection-count to memcache + redis checks

laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications

https://docs.laminas.dev/laminas-diagnostics/

BSD 3-Clause "New" or "Revised" License

55 stars 32 forks source link

Add responsetime/uptime/connection-count to memcache + redis checks #57

Closed bram123 closed 1 year ago

bram123 commented 1 year ago

Signed-off-by: Bram Leeda bram@123inkt.nl

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	no

Description

Added more CheckResult data values:

responsetime
uptime
connections

Added as a keyed array following DirWritable, or do you prefer a dataclass for this for structured data? There were no unittests for these classes unfortunately, to test this I'd need to be able to mock the Client instance.

bram123 commented 1 year ago

If this change is acceptable, I'd also like to add these stats to the PDOCheck class. Problem here is that in order to do this, I'd need to execute a query. And I know the syntax for MySQL, but I don't know a generic method to fetch this. Is a mysql specific implementation for this allowed (and empty result-data for other drivers)?