Add possibility to set zero port for memcache and memcached checkers

laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications

https://docs.laminas.dev/laminas-diagnostics/

BSD 3-Clause "New" or "Revised" License

55 stars 32 forks source link

Add possibility to set zero port for memcache and memcached checkers #64

Closed amicus-alex closed 1 year ago

amicus-alex commented 1 year ago

Q	A
Documentation	no
Bugfix	yes
BC Break	no
New Feature	no
RFC	no
QA	no

Description

It is impossible to pass zero to a port argument for Memcache and Memcached checkers when using UNIX domain sockets. But the documentation (memcache.addServer, memcached.addServer) says "As of version 2.0.0b1, set this parameter to 0 when using UNIX domain sockets."

Ocramius commented 1 year ago

A rebase on top of 1.22.x is endorsed: we changed a lot in the type analysis, so please don't try to run vimeo/psalm on this change until rebased

amicus-alex commented 1 year ago

Thank you, @Ocramius 😉