search

laminas / laminas-diagnostics

A set of components for performing diagnostic tests in PHP applications
https://docs.laminas.dev/laminas-diagnostics/
BSD 3-Clause "New" or "Revised" License
55 stars 32 forks source link

[WIP] Add support for PHP 8.4.0 #84

Open mkoprek opened 1 week ago

mkoprek commented 1 week ago
Q A
Documentation yes/no
Bugfix yes/no
BC Break yes/no
New Feature yes/no
RFC yes/no
QA yes/no

Description

mkoprek commented 1 week ago

Waiting for: https://github.com/laminas/laminas-loader/pull/13

alexmerlin commented 1 week ago

@mkoprek PHP 8.4 support added in https://github.com/laminas/laminas-loader/releases/tag/2.11.0

mkoprek commented 1 day ago

I don't have idea why it output so many error at PHPUnit 8.4 lowest. It requires specific knowledge in CI configuration which I don't have. Maybe someone can help with it?

gsteel commented 1 day ago

I don't have idea why it output so many error at PHpUnit 8.4 lowest. It requires specific knowledge in CI configuration which I don't have. Maybe someone can help with it?

To begin with run composer update; composer bump -D locally to bump dev dependencies to the latest supported releases and push again to run CI.

Many of the issues here are incompatibilities with PHPUnit and 8.4

alexmerlin commented 1 day ago

Try adding .laminas-ci.json. With this, platform dependencies will be ignored - this was done in other packages as well to fix the issue until PHP 8.4 is officially released.

mkoprek commented 23 hours ago

@alexmerlin I've added ignore_php_platform_requirements to .laminas-ci.json. There are still same errors, any other idea?

mkoprek commented 23 hours ago

To begin with run composer update; composer bump -D locally to bump dev dependencies to the latest supported releases and push again to run CI.

Many of the issues here are incompatibilities with PHPUnit and 8.4

I don't think it will help in this case. Dependencies are right now in almost newest versions.

gsteel commented 22 hours ago

I don't think it will help in this case. Dependencies are right now in almost newest versions.

I do think it will help in this case because deps are not almost newest when testing on lowest 🤷‍♂️

mkoprek commented 6 hours ago

@gsteel You was right. I was sure CI is working in other way.

There is last unit test to fix, maybe I will try to fix it at the weekend.