laminas / laminas-escaper

Securely and safely escape HTML, HTML attributes, JavaScript, CSS, and URLs
https://docs.laminas.dev/laminas-escaper/
BSD 3-Clause "New" or "Revised" License
191 stars 20 forks source link

Removed strict types from the code #22

Closed bgorski closed 3 years ago

bgorski commented 3 years ago

Signed-off-by: Bartosz Gorski bartosz.m.gorski@gmail.com

Q A
Documentation no
Bugfix no
BC Break yes
New Feature no
RFC no
QA no

Description

The introduction of declare(strict_types=1); made the change backwards incompatible with systems using laminas/laminas-escaper as a dependency in a non-strict way. For example Magento: https://github.com/magento/magento2/issues/33346 Don't get me wrong - it's an absolutely great idea to use strict types everywhere. But because of backwards incompatibility reasons, it shouldn't be enforced in a patch version increase (2.7.0 -> 2.7.1).

Ocramius commented 3 years ago

Closing: duplicate of #20 - see discussion there.