search

laminas / laminas-escaper

Securely and safely escape HTML, HTML attributes, JavaScript, CSS, and URLs
https://docs.laminas.dev/laminas-escaper/
BSD 3-Clause "New" or "Revised" License
191 stars 20 forks source link

remove maglnet/composer-require-checker as it is now in CI #35

Open internalsystemerror opened 2 years ago

internalsystemerror commented 2 years ago
Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This PR:

gsteel commented 2 years ago

Is it planned to get composer-require-checker installed by default in the ci-action container?

internalsystemerror commented 2 years ago

@gsteel Yeah I jumped the gun on this as I remember seeing that it creates the job in the CI matrix action, and assumed that the tooling was installed in there too. Then I looked at adding it and realised we're in the same position as using composer to check semver ranges, we need PHP in the node image.

This is ready to go once that is worked out however.

gsteel commented 2 years ago

That's great news - getting it installed on older PHP versions is a pain. So once implemented, it'll run require-checker on 8.0 as opposed to the matrix default stable?

internalsystemerror commented 2 years ago

Ideally, I don't think it should matter as long as it can check the composer.json file, so always using the latest version sounds ideal to me. But that is something we would need to think about when it comes to adding it.

Ocramius commented 2 years ago

Do we have a blocker PR that we can reference? I still see it running vendor/bin/composer-require-checker here

internalsystemerror commented 2 years ago

No PR yet, I thought this work was already done after checking the matrix, I missed that it was calling it from vendor/..., so I've created an issue for it instead. https://github.com/laminas/laminas-ci-matrix-action/issues/131