Closed Gounlaf closed 3 years ago
Have to rollback typehinting (BC Break)
Have to rollback typehinting (BC Break)
A rollback is correct here.
It was a reminder. I pushed another commit after that to do the rollback as required 🙂
@Gounlaf Take your time and many thanks for your help! 👍 👍 👍
I've reverted changes related to typehinting, and squash.
LGTM. I'd prefer having the
vendor/phpunit/phpunit/phpunit.xsd
instead for the schema ref but imho thats not a showstopper.
I can change it if you want
Is there release schedule for PHP 8 support? Drupal 9.1 (upcoming release) has it as dev-dependency and it's a blocker to declare PHP 8 support
@froschdesign I have commited changes according to your review. I will squash once it's OK
@Gounlaf You are fast! 😃 👍
@Gounlaf You are fast! 😃 👍
:)
I can squash so?
Thanks, @Gounlaf!
This PR should check all tasks in #8
Regards