PHP 8.0 Support - Githubissues

laminas / laminas-escaper

Securely and safely escape HTML, HTML attributes, JavaScript, CSS, and URLs

https://docs.laminas.dev/laminas-escaper/

BSD 3-Clause "New" or "Revised" License

191 stars 20 forks source link

Closed Gounlaf closed 3 years ago

Gounlaf commented 4 years ago

This PR should check all tasks in #8

Regards

Gounlaf commented 4 years ago

Have to rollback typehinting (BC Break)

Gounlaf commented 4 years ago

Have to rollback typehinting (BC Break)

A rollback is correct here.

It was a reminder. I pushed another commit after that to do the rollback as required 🙂

froschdesign commented 4 years ago

@Gounlaf Take your time and many thanks for your help! 👍 👍 👍

Gounlaf commented 4 years ago

I've reverted changes related to typehinting, and squash.

Gounlaf commented 4 years ago

LGTM. I'd prefer having the vendor/phpunit/phpunit/phpunit.xsd instead for the schema ref but imho thats not a showstopper.

I can change it if you want

andypost commented 3 years ago

Is there release schedule for PHP 8 support? Drupal 9.1 (upcoming release) has it as dev-dependency and it's a blocker to declare PHP 8 support

Gounlaf commented 3 years ago

@froschdesign I have commited changes according to your review. I will squash once it's OK

froschdesign commented 3 years ago

@Gounlaf You are fast! 😃 👍

Gounlaf commented 3 years ago

@Gounlaf You are fast! 😃 👍

I can squash so?

boesing commented 3 years ago

Thanks, @Gounlaf!