search

laminas / laminas-eventmanager

Trigger and listen to events within a PHP application
https://docs.laminas.dev/laminas-eventmanager/
BSD 3-Clause "New" or "Revised" License
1.02k stars 13 forks source link

The sections "EventManger API" and "Intercepting Filters" do not show in the "root" level #52

Closed visto9259 closed 4 months ago

visto9259 commented 4 months ago

Bug Report

Q A
Version(s) 3.x

Summary

This is a documentation bug. The sections "EventManger API" and "Intercepting Filters" do not show in the "root" level.

Current behavior

The sections "EventManger API" and "Intercepting Filters" are showing as under the "Lazy Listeners" section.

visto9259 commented 4 months ago

I will submit a fix for this

visto9259 commented 4 months ago

After looking at this further, the issue is not in the documentation for this package but in the rendering of the navigation. Theses section are under "Reference" where they should be. It's the rendering of a subsection of a section which is the issue. Sections and their subsections are not rendering with an indentation that I would have expected.

froschdesign commented 4 months ago

@visto9259 The "Reference" entry is not needed and should be removed. Compare with: https://github.com/laminas/laminas-session/pull/87

Sections and their subsections are not rendering with an indentation that I would have expected.

Deeper indents are no longer desired and must be removed.

visto9259 commented 4 months ago

Let me take a look at Session and propose something.

visto9259 commented 4 months ago

This is how it would look. I am ready to add it to the PR #53

image

froschdesign commented 4 months ago

@visto9259 Go for it! 👍🏻

Ocramius commented 4 months ago

Handled in #54