laminas / laminas-form

Validate and display simple and complex forms, casting forms to business objects and vice versa
https://docs.laminas.dev/laminas-form/
BSD 3-Clause "New" or "Revised" License
80 stars 52 forks source link

Fixes #22: "ComposedObject" Annotation does not add inputSpec to element configuration #207

Closed riul88 closed 1 year ago

riul88 commented 1 year ago

Signed-off-by: Raul Robledo riul88@gmail.com

Q A
Documentation no
Bugfix yes
BC Break yes/no
New Feature no
RFC yes/no
QA yes/no

Description

Fix suggested by @weierophinney Issue reproducible by unit test testAllowsComposingChildEntities but the test case didn't validate the filters or validators from the child entity, the unit test was updated as part of this PR to perform the missing assertions to ensure the element validators and filters are configured

The changes to unit test testAllowsComposingMultipleChildEntities which is used when ComposedObject is marked as isCollection are only preventive not impacted by the code change in the PR

Slamdunk commented 1 year ago

Thank you @riul88